Convert to MQL5

[Gillou 10]

I try without sucees to convert this code in easylanguage to MQL5 ...

 

Inputs: price(H+L+C/3);

 

Vars: M1(0),

M2(0),

V1(0),

V2(0);

 

M1 = (4*price[0]+ 3*price[1] + 2*price[2] + price[3])/10;

M2 = (4*M1[0]+ 3*M1[1] + 2*M1[2]+ M1[3])/10;

 

V1 = 2*M1-M2;

V2 = (3*V1[0] +2*V1[1] + V1[2]) /6;

 

plot1(V2,"V2");

plot2(V1,"V1");

 

Thanks to your help

[Tams 20]

I try without sucees to convert this code in easylanguage to MQL5 ...

 

Inputs: price(H+L+C/3);

 

Vars: M1(0),

M2(0),

V1(0),

V2(0);

 

M1 = (4*price[0]+ 3*price[1] + 2*price[2] + price[3])/10;

M2 = (4*M1[0]+ 3*M1[1] + 2*M1[2]+ M1[3])/10;

 

V1 = 2*M1-M2;

V2 = (3*V1[0] +2*V1[1] + V1[2]) /6;

 

plot1(V2,"V2");

plot2(V1,"V1");

 

Thanks to your help

 

 

 

What have you tried?

 

How did it fail?

[Gillou 10]

//+------------------------------------------------------------------+

//| TEST INDICATEUR |

//| |

//| |

//+------------------------------------------------------------------+

#property copyright "Pas encore de copyright LOL"

#property link "http://www.gagne-pas-encore-des-sous.com"

#property version "1.00"

 

#property indicator_chart_window

#property indicator_buffers 2

#property indicator_plots 2

#property indicator_color1 Red

#property indicator_color2 Blue

#property indicator_type1 DRAW_LINE

#property indicator_type2 DRAW_LINE

#property indicator_style1 STYLE_SOLID

#property indicator_style2 STYLE_SOLID

#property indicator_width1 1

#property indicator_width2 1

 

//---- indicator parameters

 

 

//---- indicator buffers

double ExtMapBuffer1[];

double ExtMapBuffer2[];

 

double V1[];

double V2;

double H1[];

double H2;

 

//+------------------------------------------------------------------+

//| Custom indicator initialization function |

//+------------------------------------------------------------------+

int OnInit()

{

//--- set empty value

PlotIndexSetDouble(1,PLOT_EMPTY_VALUE,0.0);

PlotIndexSetDouble(2,PLOT_EMPTY_VALUE,0.0);

 

//---- indicator buffers mapping

SetIndexBuffer(1,ExtMapBuffer1,INDICATOR_DATA);

SetIndexBuffer(2,ExtMapBuffer2,INDICATOR_DATA);

//---- initialization done

return(0);

}

 

//+------------------------------------------------------------------+

//| Data Calculation Function for Indicator |

//+------------------------------------------------------------------+

int OnCalculate(const int rates_total,

const int prev_calculated,

const datetime &time[],

const double &open[],

const double &high[],

const double &low[],

const double &Close[],

const long &tick_volume[],

const long &volume[],

const int &spread[])

{

ArraySetAsSeries(low, true);

ArraySetAsSeries(high, true);

ArraySetAsSeries(Close, true);

 

//Fill buffers with zero values for the first run

if (prev_calculated == 0)

{

ArrayInitialize(ExtMapBuffer1,0.0);

ArrayInitialize(ExtMapBuffer2,0.0);

}

 

indic(Close, rates_total);

 

//---- done

return(rates_total);

}

 

//+------------------------------------------------------------------+

//| Simple test d affichage avec le calcul sur Close uniquement |

//+------------------------------------------------------------------+

void indic(const double &Close[], int rates_total)

{

int pos = 0 ;

 

 

//---- boucle de calcul

while (pos < rates_total - 7)

{

H1[pos] = (4 * Close[pos] + 3 * Close[pos+1] + 2 * Close[pos+2] + Close[pos+3]) / 10;

 

H2 = (4 * H1[pos] + 3 * H1[pos+1] + 2 * H1[pos+2] + 1 * H1[pos+3] ) / 10;

 

V1[pos] = ( 2 * H1[pos] - H2 );

 

V2 = ( 3 * V1[0] + 2 * V1[1] + V1[2] ) /6;

 

ExtMapBuffer1[pos] = V1[pos];

 

ExtMapBuffer2[pos] = V2;

 

pos++;

}

}

 

I'm a newbie in MQL5, I have a "array out of range in 'test.mq5' (92,7) " and nothing in the screen (no compile error)...

[onesmith 10]

Comment out all lines that attempt to access the array. Uncomment them one at a time until you find the lines that do not cause the error. You will have to switch the indicator back to on within your chart each time you make one of these changes because the chart looks for different errors that the compiler doesn't look for.

 

Eventually you will have succeeded in limiting the bug to the few lines of code that are causing it. Then if you still can't guess exactly what's causing it try adding new lines one at a time that progressively test different levels of the same ideas in the lines of code you know are causing the problem. In other words, you want to write a new line of code that defines the smallest case of this bug and then add complexity if you have more than one case or class of bugs.

 

If you keep everything simple then it is relatively easy to find where the bug is.