Jump to content

Welcome to the new Traders Laboratory! Please bear with us as we finish the migration over the next few days. If you find any issues, want to leave feedback, get in touch with us, or offer suggestions please post to the Support forum here.

  • Welcome Guests

    Welcome. You are currently viewing the forum as a guest which does not give you access to all the great features at Traders Laboratory such as interacting with members, access to all forums, downloading attachments, and eligibility to win free giveaways. Registration is fast, simple and absolutely free. Create a FREE Traders Laboratory account here.

ValueTrader

Automation Not Working

Recommended Posts

Hello Everyone,

 

I've been coding some EL automated stratgies on my OEC platform, with some success.

 

The latest one is causing me problems however...

 

The original code was 'Dynamic S&R' which if im correct, TAMS kindly posted on the forum.

 

I made a couple of alterations to the original code, and as a result have a nice S&R indicator that works along the lines of Don Jones' Auction Market Value Theory Principles.

 

The next logical step for me was to try to automate it into a strategy. However when i come to backtest, it isnt placing any orders. I've mest around with the wordings, setting and everything elsei can think of. Can anyone Help?

 

All i need it to do is at least place some trades, i can then alter the parameters / conditions to suit. The Buy / Sell commands are exactly the same as other Codes i've done, So i'm obviously missing something. Thanking you all in advance

 

inputs:


iMode("No"),	{ if "auto" code sets xPeriods, if not "auto" code uses iPeriods}

iPeriods(05),
HighColor(  red), 
LowColor(  blue) ;

variables:

xPeriods(60),
xInterval(0),
sFirstPass(true),
HavePrevLines( false ), 
TLHigh( 0 ), 
TLLow( 0 ), 
PushHigh( 0 ), 
PushLow( 0 ),
OldPushHigh( 0 ), 
OldPushLow( 0 ),
PrevPushHigh( 0 ), 
PrevPushLow( 0 ) ,
Uo(0),Mid(0),Lo(0),Range(0);

{first time through}

if sFirstPass
then begin

sFirstPass = false;

{bar test}

If bartype = 4
then xInterval = 94
else
If bartype = 3
then xInterval = 93
else
If bartype = 2
then xInterval = 92
else
If bartype = 1
then begin
xInterval = BarInterval;
end; { If bartype = 1  }

{mode test}

If iMode <> "Auto" and iMode <> "auto" and iMode <> "AUTO"
   then xPeriods = iPeriods
else xPeriods = _fPushPeriods(xInterval);

end; {if sFirstPass}

{save old values}

If PushHigh <> PrevPushHigh
then OldPushHigh = PrevPushHigh;

If PushLow <> PrevPushLow 
then OldPushLow  = PrevPushLow ;

OldPushHigh = PrevPushHigh ;
OldPushLow = PrevPushLow ;

PrevPushHigh = PushHigh ;
PrevPushLow = PushLow ;

{ high / low for period }

PushHigh = Highest( H, xPeriods);
PushLow  = Lowest( L, xPeriods) ;

If PushHigh <> H
and PushHigh < PrevPushHigh
then PushHigh = PrevPushHigh;

If PushLow <> L
and PushLow > PrevPushLow
then PushLow = PrevPushLow;

Range=PushHigh-PushLow;

Uo=PushHigh-Range/8;

Mid=Range/2+PushLow;

Lo=PushLow+Range/8;

//Removed plots from here//

if open[2] < Lo then if Close > Lo  Then Buy next bar at Market; 
if open[2] > Uo then if Close < Uo Then Sell Next Bar at Market;
SetDollarTrailing(250);



#function _fPushPeriods
inputs: iInterval(NumericSimple); 
variables: xPeriods(60); 
{ calculations } 
If iInterval < 5 then xPeriods = 60 else 
If iInterval < 10 then xPeriods = 45 else 
If iInterval = 10 then xPeriods = 6 else 
If iInterval = 15 then xPeriods = 12 else 
If iInterval = 30 then xPeriods = 4 else 
If iInterval = 60 then xPeriods = 6 else 
If iInterval > 60 then xPeriods = 10; 
_fPushPeriods = xPeriods;

Share this post


Link to post
Share on other sites
Hello Everyone,

...

All i need it to do is at least place some trades, i can then alter the parameters / conditions to suit. The Buy / Sell commands are exactly the same as other Codes i've done, So i'm obviously missing something. Thanking you all in advance

...

 

have you tested your buy/sell triggers with a plot?

 

add this to the plot:

 

if barstatus = 2 then 
begin
    {--- plot buy/sell logic here---}
end;

Share this post


Link to post
Share on other sites

Ok, Thanks TAMS:), I can now see whats happend... I added this code

if open[2] < Lo then if Close > Lo Then Plot6(L,"Long"); 
if open[2] > Uo then if Close < Uo Then Plot7(S,"Short");

 

along with the associated Vars, to the Indicator, as OEC does not plot in strategy mode (maybe its the same in TS? i dont know), anyway, and my intermediate S&R that is

Uo(0),Mid(0),Lo(0),Range(0)

have dissapeared, so something in the commands

if open[2] < Lo then if Close > Lo Then Plot6(L,"Long"); 

is telling the Lo (which stands for Lower Octant) to change, instead of trading off it. This possibilty had already crossed my mind, but as i say my other strategys use varables (PVP,VWAP,Volume delta) all from home cooked indicators to signal entrys with no problem, so im still stumpped!

Share this post


Link to post
Share on other sites
Ok, Thanks TAMS:),... OEC does not plot in strategy mode (maybe its the same in TS? i dont know), ...

 

Neither TS nor MC plots in strategy mode.

 

as part of your programming steps,

you MUST first use the plot IN PLACE of buy/sell in your system development.

 

ie

 

replace the following code

if open[2] < Lo then if Close > Lo  Then Buy next bar at Market; 
if open[2] > Uo then if Close < Uo Then Sell Next Bar at Market;

 

with


if barstatus = 2 then
begin
    if open[2] < Lo then if Close > Lo Then plot10(high, "BUY"); 
    if open[2] > Uo then if Close < Uo Then plot10(low, "SELL");
end;

 

set the plot to a large dot...

you can then visually verify whether your code is actually triggering the buy/sell orders at the places you wanted them to.

 

if you can see the dots in your indicator... but the strategy's orders are not getting filled... then the problem is with the broker.

 

if you CANNOT see the dots in your indicator... then the strategy's orders are not getting TRIGGERED...

the problem is with the logic.

you then have to verify each variable has the appropriate value at each stage of the logic development.

Edited by Tams

Share this post


Link to post
Share on other sites

That works.

 

I can see dots on entry points, I can now fine tune these in the indicator mode.

 

I assume once im happy with the entrys i can simply change the plot statement to buy @ market for backtesting on the strat mode?

 

Thanks TAMS

 

VT

Share this post


Link to post
Share on other sites
That works.

 

I can see dots on entry points, I can now fine tune these in the indicator mode.

 

I assume once im happy with the entrys i can simply change the plot statement to buy @ market for backtesting on the strat mode?

 

Thanks TAMS

 

VT

 

that's right... always visually inspect the trigger points first... before jumping to the order managements.

 

good to hear your logic is working.

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Topics

  • Posts

    • META stock watch, local support and resistance areas at 507.48, 557.84 at https://stockconsultant.com/?META
    • TMUS T-Mobile stock, watch for a top of range breakout at https://stockconsultant.com/?TMUS
    • KULR KULR Technology stock watch, pullback to 1.25 triple support area with bullish indicators at https://stockconsultant.com/?KULR
    • PM Philip Morris stock, nice bull flag breakout with volume +91% at https://stockconsultant.com/?PM
    • Date: 4th April 2025.   USDJPY Falls to 25-Week Low as Safe Havens Surge and Markets Eye NFP Data.   Safe haven currencies and the traditional alternative to the US Dollar continue to increase in value while the Dollar declines. Investors traditionally opt to invest in the Japanese Yen and Swiss Franc at times of uncertainty and when they wish to avoid the Dollar. The Japanese Yen continues to be the best-performing currency of the week and of the day. Will this continue to be the case after today’s US employment figures?   USDJPY - NFP Data And Trade Negotiations The USDJPY is currently trading at a 25-week low and is witnessing one of its strongest declines this week. The exchange rate is no longer obtaining indications from the RSI that the price is oversold. The current bullish swing is obtaining indications of divergence as the price fails to form a higher high. Therefore, short-term momentum is in favour of the US Dollar, but there are still signs the Japanese Yen can regain momentum quickly.       USDJPY 1-Hour Chart     The price movement of the exchange rate in both the short and long term will depend on 3 factors. Today’s US employment data, next week’s inflation rate and most importantly the progress of negotiations between the US and trade partners. If today’s Unemployment Rate increases above 4.1%, the reading will be the highest seen so far in 2025. Currently, the market expects the Unemployment Rate to remain at 4.1% and the Non-Farm Payroll Change to add 137,000 jobs. The average NFP reading this year so far has been 194,000.   If data does not meet expectations, US investors may continue to increase exposure away from the Dollar and to other safe-haven assets. Previously investors were expecting only 2 rate cuts this year from the Federal Reserve, however, most investors now expect up to 4. If today’s employment data deteriorates, economists advise the Federal Reserve may opt to cut interest rates sooner.   Therefore, it is important to note that today’s NFP will influence the USDJPY to a large extent. Whereas in the longer-term, trade negotiations will steal the spotlight. If trade partners are able to negotiate the US Dollar can correct back upwards. Whereas, if other countries retaliate and do not negotiate the US Dollar will remain weak.   USDJPY - The Yen and the Bank of Japan The Japanese Yen is the best-performing currency in 2025 increasing by 6.70% so far. Risk indicators such as the VIX and High-Low Indexes continue to worsen which is positive for the JPY as a safe haven currency.   Yesterday Japan released March business activity data that came in weaker than expected: the Services PMI dropped from 53.7 to 50.0, while the Composite PMI fell from 52.0 to 48.9. The data is the lowest in two years. These figures could hinder further interest rate hikes by the Bank of Japan. However, most economists still expect the Bank Of Japan to hike at least once more. It's also important to note, that even if the BOJ opts for a prolonged pause, a cut is not likely.   Additionally, a 24% tariff was imposed on Japanese exports to the US yesterday. Prime Minister Mr Ishiba expressed disappointment over Japan's failure to secure a tariff exemption and pledged support measures to help domestic industries manage the impact.   Key Takeaway Points: US Dollar Weakens, Safe Havens Rise: The Japanese Yen and Swiss Franc continue to gain as investors shift away from the US Dollar. USDJPY Under Pressure: USDJPY trades at a 25-week low, with short-term momentum favouring the Dollar but long-term trends pointing to potential Yen strength. NFP and Unemployment Crucial: Today’s Non-Farm Payrolls and unemployment figures will heavily influence short-term USDJPY. On the other hand, trade negotiations will dictate longer-term trends. Japan Faces Mixed Signals: Despite weak PMI data and new US tariffs, the Japanese Yen remains strong. Economists expect at least one more rate hike from the Bank of Japan, but no cuts are in sight. Always trade with strict risk management. Your capital is the single most important aspect of your trading business.   Please note that times displayed based on local time zone and are from time of writing this report.   Click HERE to access the full HFM Economic calendar.   Want to learn to trade and analyse the markets? Join our webinars and get analysis and trading ideas combined with better understanding of how markets work. Click HERE to register for FREE!   Click HERE to READ more Market news.   Michalis Efthymiou HFMarkets   Disclaimer: This material is provided as a general marketing communication for information purposes only and does not constitute an independent investment research. Nothing in this communication contains, or should be considered as containing, an investment advice or an investment recommendation or a solicitation for the purpose of buying or selling of any financial instrument. All information provided is gathered from reputable sources and any information containing an indication of past performance is not a guarantee or reliable indicator of future performance. Users acknowledge that any investment in Leveraged Products is characterized by a certain degree of uncertainty and that any investment of this nature involves a high level of risk for which the users are solely responsible and liable. We assume no liability for any loss arising from any investment made based on the information provided in this communication. This communication must not be reproduced or further distributed without our prior written permission.
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.