MCFX Power Language(Easy Language) Coding Issue

[fireworkz 10]

Hello Everyone!

 

I am having an issue with the following code. It is not performing when I apply it to the charts as it should and I have no clue why.

 

Vars: OverSold(25),

Price(Close),

AVGLength(66),

PRLength(6),

AVG(0);

 

AVG = Average(Price, AVGLength);

if AVG < Price and (PercentR(PRLength)) < OverSold then

Buy("Test") Next Bar at Market;

 

The code is very simple. When the closing price is greater then the average of the last 66 closing prices AND PercentR returns a value less then 25 it should trigger a buy.

 

But it does not. Is there an issue with comparing averages within easy language or power language which is suppose to be identical to each other.

 

When I apply this code to the charts it does not generate any order what so ever even though the conditions are right. However when I used a different function that I created to calculate the average instead of the built in Average() function it triggered buy signals but the signals where wrong. It would buy when PercentR was oversold but when price was was below the average or above or randomly. It made no sense.

 

I am completely confused. I understand Easy Language very well but I can not figure out why this simple code will not work. I spent a whole day messing with different things and nothing seems to work right.

 

Any help is much appreciated...

[Tams 20]

have you tested this out as an indicator first?

 

how could you know it was not GIGO ?

Edited February 24, 2010 by Tams

[fireworkz 10]

Well for the Avg to plot as an indicator the following code has to be used which doesn't make much sense.

 

//Declare Variables

Inputs: Price(Close), Length(66), Displace(0);

Vars: Avg(0);

 

Avg = Average(Price, Length);

 

condition1 = Displace >= 0 or CurrentBar > AbsValue( Displace ) ;

if condition1 then

begin

Plot1[Displace]( Avg, "Will-Trend" ) ;

Print("Avg = ", Avg);

 

 

if Displace <= 0 then

begin

condition1 = Price crosses over Avg ;

if condition1 then

Alert( "Will-Trend: Long Term Trend Is Up")

 

else

begin

condition1 = Price crosses under Avg ;

if condition1 then

Alert( "Will-Trend: Long Term Trend Is Down" ) ;

end ;

end;

end ;

 

I really don't understand the reason for the displace variable and don't see why it wouldn't plot correctly by using this code:

 

Avg = Average(Price, Length);

Plot1(Avg, "Avg");

 

Shouldn't it be that simple? Since the code gets processed each bar? But this simple code doesn't plot the Average on the chart. I had to look at a sample 1 line moving average that was already in the program to see how they did it.

 

But the thing is, I don't need to chart the Average. I need to compare the whether the price is above or below the average so I can signal a buy/sell along with other conditions...

 

When I print the avg value which the first coding I posted... it stays at 1.40.

 

When I print for the indicator code avg value it prints shows the avg is changing correctly. Even though is only shows to the second decimal. I don't knot if thats the print or hwo the average is being calucalted but the price for forex is always atleast 4 decimals for EUR/USD...

 

Anyone have the slightest clue how do get this to work? I am messing with the indicator coding to see if I can get the same results but with comparing the variable (nopt plotting it) but so far no luck..

[Tams 20]

in your 1st post,

the price is declared under var:

 

the value of price will be assigned at initiation

and will remain at that vlue.

 

if you move the price to input (as in the second code),

the value of price will be re-evaluated at every tick.

 

alternatively you can add this line before the avg calculation:

price = close;

 

 

hope this helps.

Edited February 26, 2010 by Tams

[statsign 10]

take values and string them and then print them because of the 2 dec place limit for float in the output bar

 

just a print tip since your coding problem was solved