Jump to content

Welcome to the new Traders Laboratory! Please bear with us as we finish the migration over the next few days. If you find any issues, want to leave feedback, get in touch with us, or offer suggestions please post to the Support forum here.

  • Welcome Guests

    Welcome. You are currently viewing the forum as a guest which does not give you access to all the great features at Traders Laboratory such as interacting with members, access to all forums, downloading attachments, and eligibility to win free giveaways. Registration is fast, simple and absolutely free. Create a FREE Traders Laboratory account here.

PeterBrazel

Reset or Clear Each New Bar

Recommended Posts

I have created some code that displays some calculations on the current bar and need to clear this information and start the calculation over on each new bar.

 

I have tried this:

if LastBarOnChart and BarStatus( 1 ) = 2 then

 

but nothing displays using this statement.

Here is the code that I want to reset each bar....

Ltxt = text_new(date,time,close," ");
	text_SetLocation(Ltxt,date,CalcTime(time,RightOffset),Close-(txtOff));
	text_SetString(Ltxt,"     "+SEtxt+RightStr(NumtoStr(LoE,Dec),TTrun));
	text_SetColor(Ltxt,Locolor);

 

Any suggestions appreciated.

Share this post


Link to post
Share on other sites

try this:

 

if currentbar = 1 then Ltxt = text_new(date,time,close," ");

text_SetLocation(Ltxt,date,CalcTime(time,RightOffset),Close-(txtOff));
text_SetString(Ltxt,"     "+SEtxt+RightStr(NumtoStr(LoE,Dec),TTrun));
text_SetColor(Ltxt,Locolor);

 

 

 

;-)

Share this post


Link to post
Share on other sites

Thanks Tams.

 

But this does not seem to work. When I add this nothing plots at all.

 

Perhaps I will provide a little more of my code

 

   	//-- Intra-bar (Minute) Chart Timer -------------------------
if 		BarType = 1 
then begin
	// Grab Computer Time at End-of-Bar and calc end-time
if 	BarStatus(1) = 2 then
	dtEndTime = ComputerDateTime + dtBarTime;		

	// Calc Time Left and Display
if 		dtEndTime <> 0 
then begin
	// Calc Time Left & Pct. Left
	dtTimeLeft = dtEndTime - ComputerDateTime;
	BarLeftPct = (dtTimeLeft / dtBarTime) * 100;
	// Format the text
if 	DispMode = cDispPct 
then  
	TxtStr = NumToStr(BarLeftPct, 0)+"%"+Pad
else if 
	DispMode = cDispRaw 
then
	TxtStr = FormatTime("m:ss", dtTimeLeft)+" "{+Pad};
end 
else 
	TxtStr = "Syncing..."+Pad;

	// Display Text
	text_setstring(TxtID," < "+ TxtStr+"R:"+NumToStr(Risk,0)+" ["+NumToStr((RiskOffset),0)+"]"+ATxt);
	//// Entry Text	


	Htxt = text_new(date,time,close," ");
	text_SetLocation(Htxt,date,CalcTime(time,RightOffset),Close+({2*}txtOff));
	text_SetString(Htxt,"     "+LEtxt+RightStr(NumtoStr(HiE,Dec),TTrun));
	text_SetColor(Htxt,hicolor);

	Ltxt = text_new(date,time,close," ");
	text_SetLocation(Ltxt,date,CalcTime(time,RightOffset),Close-(txtOff));
	text_SetString(Ltxt,"     "+SEtxt+RightStr(NumtoStr(LoE,Dec),TTrun));
	text_SetColor(Ltxt,Locolor);

Share this post


Link to post
Share on other sites
Thanks Tams.

 

But this does not seem to work. When I add this nothing plots at all.

 

Perhaps I will provide a little more of my code ...

 

 

 

Peter:

 

remove all occurrences of these codes from your indicator: (all TEXT_NEW)

 

Htxt = text_new(date,time,close," ");
Ltxt = text_new(date,time,close," ");

 

and add this to the beginning of the your indicator. (right after the variables)

 

if currentbar = 1 then 
begin
   Htxt = text_new(date,time,close," ");
   Ltxt = text_new(date,time,close," ");
end;

 

 

 

the idea is this:

 

at bar #1, you draw a text object to the chart.

 

bar #1 is somewhere to the left of your chart... but you really don't care where that is.

you only draw that once, because currentbar = 1 only happens one time.

 

subsequently when your conditions are triggered,

your code reloactes the text object to a new location,

and your code reassigns a new value to the text object...

 

when a new condition is triggered again,

your code reloactes the text object to a new location... yet again !!!

and your code reassigns a new value to the text object...... yet again !!!

 

 

how come you do not see repeated text objects on your chart?

because you have only drew it once.... at bar #1.

 

 

enjoy !

Edited by Tams

Share this post


Link to post
Share on other sites

Tams,

 

You are a gentleman. When I followed your instructions nothing plotted at all. I believe I understand conceptually what you are saying.

 

Here is the complete code thus far.

{=====================================================================
NAME:  	BarCountdownTimer

TYPE:	Indicator
AUTHOR:	Bill Conley (AKA Kahuna) - Timer Counter
		Peter Brazel - Risk, Bossilator and other features. 
OUTPUT:
		This countdown timer works on Intrabar, Tick or Volume charts. 
		It displays the Time, Ticks or Volume remaining in a bar as text
	 	to the right of the last bar and a user defined portion of the 
		way up the chart (VertTextPct input).  It provides an option to 
		display remaining bar as a percent of the bar interval size. It 
		changes color from Normal Color (NormColor input) to Alert Color 
		(AlertColor input) when the bar reaches the Alert level 
		percent (AlertPct input).  A TS alert is also triggered which
		the trader can chose to enable via the TS Alerts tab.  This 
		alerts the trader as the bar is ending.
INPUTS:
		VertTextPct - Percent of chart window height at which to display timer (Default: 80)
		NormColor - Color for normal (non-alert) text display (Default: yellow)
		AlertColor - Color for alert text display (Default: red)
		AlertPct - Alert when this percentage of the bar remains (Default: 10),
		DispMode - Display mode option: 1=Percentage, 2=Time/Ticks/Volume (Default: 2)

COMMENTS:
		For use with intrabar, tick and share bar charts only. For Volume
	 	(Sharebar) charts, make sure Volume is set to "Trade Vol" and for
	 	Tick charts set volume to "Tick Count" for proper operation 
	 	of indicator. 

RELEASE NOTES:
		V. 1.0 10/08/09	Initial Version

== Inputs & Variables =================================================}

inputs:		RiskDisplaySettings(""),
		EntryBar(1), 			//Risk Calc Entry Bar 1=1 bar back
		Dec(4),	
		Mult(10000), 			//Multiplier to convert ticks to $
		RiskOffset(1), 			// E.G. 1 Tick above the high to enter long
		TextOff(1),
		TruncateTxt(2), 		//Numbers to display for swings. Default=3 e.g. 1.3456 will display 456
		LETxt("LE :"),
		SETxt("SE :"),
		HiColor(Cyan),
		LoColor(Magenta),
		CounterSettings(""),
		VertTextPct(80{0-100}),
		RightOffset(1),
		NormColor(yellow),
		AlertColor(red),
		AlertPct(10{0-100}),
		DispMode(2 {1=Pct,2=Time/Ticks/Vol})
		;

vars:		TickSize( MinMove / PriceScale ), 
			{		IntrabarPersist Bar_Number( 0 ),
				IntrabarPersist Bar_Ticks ( 0 ),}
		HiE(0),
		LoE(0),
		Risk(0),
		TxtOff(0),
		TextID(0),
		txt(""),
		ATxt(""),
		Htxt(-1),
		LTxt(-1),
		R1T(-1),
		TicksLeft(0),
		color(0),
		TTrun(0),
		EB(0),

		{Timer}
		{ Text Object Vars }
		TxtStr(""),		// Text String  
		AlertStr(""),	// Alert Text String  
		TxtID(text_new(date,time,close, " ")),		// Text Object Reference
		{ Time/Ticks/Vol Vars }
		dtEndTime(0),	// EndTime for Bar
		dtTimeLeft(0),	// Time Left in Bar
		dtBarTime(0),	// Total Time in Bar
		BarLeftPct(0),	// Percent of Bar Remaining
		BarLeftAmt(0),	// Bar Remaining in Ticks/Vol
		{ Constants }
		cDispPct(1),	// Option to display Percentages
		cDispRaw(2),	// Option to display Time/Tick/Vol Values
		cMinDayInv(1/1440),	// One Min portion of day
		Pad("         ")	// Pad to right of text display
		;
// Other Calcs
		TTrun=TruncateTxt;
		HiE=High[EB]+(RiskOffset*TickSize);
		LoE=Low[EB]-(RiskOffset*TickSize);
		TxtOff=(TextOff*TickSize);
		Risk=(HiE-LoE)*Mult; {HL*Mult;}

		EB = EntryBar;

{== Timer Initialization ===================================================}

once begin
	// Check for valid chart
if 	BarType <> 0 and BarType <> 1 then
	RaiseRuntimeError(
		"Countdown Timer is only supported on Intrabar, Tick or Volume Charts");
	// Check for valid input values
if 	DispMode <> 1 and DispMode <> 2 then
	RaiseRuntimeError("The DispMode input must be set to 1 or 2");
if 	VertTextPct > 100 or VertTextPct < 0 then
	RaiseRuntimeError("The VertTextPct input must be set between 0 and 100");
if 	AlertPct > 100 or AlertPct < 0 then
	RaiseRuntimeError("The AlertPct input must be set between 0 and 100");
	// Chart Specific Init
if 	BarType = 1 then begin 		// Intrabar Chart 
		dtBarTime = cMinDayInv * BarInterval;
if 	DispMode = cDispRaw then
	AlertStr = GetSymbolName+" bar has "+NumToStr(BarInterval*60*(AlertPct/100),0)+" seconds remaining"
else
	AlertStr = GetSymbolName+" bar has "+NumToStr(AlertPct,0)+"% remaining";
end
else if 	BarType = 0 then begin	// Tick/Vol Chart
if 			DispMode = cDispRaw then
			AlertStr = GetSymbolName+" bar has "+NumToStr(BarInterval*(AlertPct/100),0)+" ticks/vol remaining"
else
			AlertStr = GetSymbolName+" bar has "+NumToStr(AlertPct,0)+"% remaining";
end;
end;

{== Timer Calculations ====================================================}

if _LastBarOnChart then begin // Only display in real-time

	// Set Text Location from right of chart
	//Value2 = Text_FloatLocation(TxtID, VertTextPct);
	Value2=Text_SetLocation(TxtID, Date, CalcTime(Time,RightOffset), Close);
	{TextID = Text_New(Date, Time, Close, " ");
	Text_SetLocation(TextID, Date, CalcTime(Time,RightOffset), Close);
	text_SetString(TextID," < "+NumToStr(value1,0)+"  R : "+NumToStr(Risk,0)+" ["+NumToStr((RiskOffset),0)+"]"+ATxt);
	text_SetColor(TextID,color);}

	//Value2=Text_SetLocation(TextID, Date, CalcTime(Time,RightOffset), Close);
   	//-- Intra-bar (Minute) Chart Timer -------------------------
if 		BarType = 1 
then begin
	// Grab Computer Time at End-of-Bar and calc end-time
if 	BarStatus(1) = 2 then
	dtEndTime = ComputerDateTime + dtBarTime;		

	// Calc Time Left and Display
if 		dtEndTime <> 0 
then begin
	// Calc Time Left & Pct. Left
	dtTimeLeft = dtEndTime - ComputerDateTime;
	BarLeftPct = (dtTimeLeft / dtBarTime) * 100;
	// Format the text
if 	DispMode = cDispPct 
then  
	TxtStr = NumToStr(BarLeftPct, 0)+"%"+Pad
else if 
	DispMode = cDispRaw 
then
	TxtStr = FormatTime("m:ss", dtTimeLeft)+" "{+Pad};
end 
else 
	TxtStr = "Syncing..."+Pad;

	// Display Text
	text_setstring(TxtID," < "+ TxtStr+"R:"+NumToStr(Risk,0)+" ["+NumToStr((RiskOffset),0)+"]"+ATxt);
	//// Entry Text	

if currentbar = 1 then 
begin
   Htxt = text_new(date,time,close," ");
   Ltxt = text_new(date,time,close," ");
end;

	text_SetLocation(Htxt,date,CalcTime(time,RightOffset),Close+({2*}txtOff));
	text_SetString(Htxt,"     "+LEtxt+RightStr(NumtoStr(HiE,Dec),TTrun));
	text_SetColor(Htxt,hicolor);

	{Ltxt = text_new(date,time,close," ");}
	text_SetLocation(Ltxt,date,CalcTime(time,RightOffset),Close-(txtOff));
	text_SetString(Ltxt,"     "+SEtxt+RightStr(NumtoStr(LoE,Dec),TTrun));
	text_SetColor(Ltxt,Locolor);

	///////
	// Trigger Alert / Use Alert Color
if 	dtEndTime <> 0 and 
	BarLeftPct < AlertPct 
then begin 
	text_SetColor(TxtID, AlertColor);
	Alert(AlertStr);
end
else
	text_SetColor(TxtID, NormColor);
end
	//-- Tick/Volume Chart Timer -------------------------------
else 
if 		BarType = 0 
then begin

	// Calc Bar Remaining 
	BarLeftAmt = BarInterval - Ticks;
	BarLeftPct = (BarLeftAmt / BarInterval) * 100;

	// Calc Remaining value
if 	DispMode = cDispPct then  
	TxtStr = NumToStr(BarLeftPct, 0)+"%"+Pad
else if 
	DispMode = cDispRaw 
then
	TxtStr = NumToStr(BarLeftAmt, 0)+" "+Pad;
	// Display Text

	text_setstring(TxtID," <"+ TxtStr+"R:"+NumToStr(Risk,0)+" ["+NumToStr((RiskOffset),0)+"]"+ATxt);

	// LS Entry Txt

if currentbar = 1 then 
begin
   Htxt = text_new(date,time,close," ");
   Ltxt = text_new(date,time,close," ");
end;


	{Htxt = text_new(date,time,close," ");}
	text_SetLocation(Htxt,date,CalcTime(time,RightOffset),Close+({2*}txtOff));
	text_SetString(Htxt,"     "+LEtxt+RightStr(NumtoStr(HiE,Dec),TTrun));
	text_SetColor(Htxt,hicolor);

	{Ltxt = text_new(date,time,close," ");}
	text_SetLocation(Ltxt,date,CalcTime(time,RightOffset),Close-(txtOff));
	text_SetString(Ltxt,"     "+SEtxt+RightStr(NumtoStr(LoE,Dec),TTrun));
	text_SetColor(Ltxt,Locolor);

	// Trigger Alert / Use Alert Color
if 		BarLeftPct < AlertPct
then begin  
	text_SetColor(TxtID, AlertColor);
	Alert(AlertStr);
end
else begin
	text_SetColor(TxtID, NormColor);
end;
end;
end;

Share this post


Link to post
Share on other sites
Tams,

 

You are a gentleman. When I followed your instructions nothing plotted at all. I believe I understand conceptually what you are saying.

 

Here is the complete code thus far...

 

 

try simplify your code to isolate the problem...

 

e.g.

change CalcTime(Time,RightOffset) to TIME

change Close-(txtOff) to CLOSE

change text_SetString(Ltxt," "+SEtxt+RightStr(NumtoStr(LoE,Dec),TTrun));

to text_SetString(Ltxt, " THIS IS A TEST ");

 

 

ie. test the TEXT_SETLOCATION concept to make sure it works... before adding additional parameters and/or variables.

Share this post


Link to post
Share on other sites

Tams,

 

The code that produces the text works fine except that it does not clear when a new bar begins.

 

Attached is a screenshot of the code plotting the first time exactly as it should.

 

I will review your posts tomorrow as there is some small adjustment following your logic that should provide my answer.

 

Thank you for your assistance.

Text.png.cf2c022d72e026c65287983b0925c466.png

Share this post


Link to post
Share on other sites
Tams,

 

The code that produces the text works fine except that it does not clear when a new bar begins.

 

Attached is a screenshot of the code plotting the first time exactly as it should.

 

I will review your posts tomorrow as there is some small adjustment following your logic that should provide my answer.

 

Thank you for your assistance.

 

 

is that because you have 2 text objects going at the same time?

 

think... if you want Htxt to print, but not Ltxt,

where would you want to put Ltxt?

Share this post


Link to post
Share on other sites

Have you checked the reserved word

Text_Delete(keyId)

?

 

Setting the

Text_setstring to "" / empty string

?

 

Using

Text_SetLocation()

to move the text far out of sight if condition

?

 

hth

Share this post


Link to post
Share on other sites

I want both the Long Entry and the Short entry price level to be displayed based on a breach of the H or L of a prior bar by x ticks.It all seems to work when I apply the indicatlor until the next bar is formed. It then leaves a trail of the LE and SE for each bar. So your comments about resetting so that only the current bar displays the text is valid. How I achieve it seems to be the issue. If I make the changes you suggest then nothing at all displays. The counter itself with the risk detail works OK but not the LE and the SE. So I am in a spot over this right now. Of course I took the counter from the TS forum and I have quite a bit of stuff that I would like to add to it but all that I want to add has to be treated in this manner. My trades are entered manually on a seperate platform so I want to always have the information readily available to me.

Share this post


Link to post
Share on other sites
I want both the Long Entry and the Short entry price level to be displayed based on a breach of the H or L of a prior bar by x ticks.It all seems to work when I apply the indicatlor until the next bar is formed. It then leaves a trail of the LE and SE for each bar. So your comments about resetting so that only the current bar displays the text is valid. How I achieve it seems to be the issue. If I make the changes you suggest then nothing at all displays. The counter itself with the risk detail works OK but not the LE and the SE. So I am in a spot over this right now. Of course I took the counter from the TS forum and I have quite a bit of stuff that I would like to add to it but all that I want to add has to be treated in this manner. My trades are entered manually on a seperate platform so I want to always have the information readily available to me.

 

 

when I applied your code to my chart, the text objects where relocating without a previous trace.

:confused:

 

you must have another text_new there somewhere...

 

 

as long as you understand the concept... and tested the basic functionality to be working... you are in good hands.

 

you just have to trace the code line-by-line to flush out the bug.

 

Good luck.

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Topics

  • Posts

    • AMZN Amazon stock, nice buying at the 187.26 triple+ support area at https://stockconsultant.com/?AMZN
    • DELL Dell Technologies stock, good day moving higher off the 90.99 double support area, from Stocks to Watch at https://stockconsultant.com/?DELL
    • MCK Mckesson stock, nice trend and continuation breakout at https://stockconsultant.com/?MCK
    • lmfx just officially launched their own LMGX token, Im planning to grab a couple of hundred and maybe have the option to stake them. 
    • Date: 2nd April 2025.   Market on Edge: Tariff Announcement and Volatility Ahead!   The US economic and employment data continues to deteriorate with the job vacancies figures dropping to a 5-month low. In addition to this, the IMS Manufacturing PMI also fell below expectations. However, both the US Dollar and Gold declined simultaneously following the release of the two figures, an uncommon occurrence in the market. Traders expect a key factor to be today’s ‘liberation day’ where the US will impose tariffs on imports. USDJPY - Traders Await Tariff Confirmation! Traders looking to determine how the USDJPY will look today will find it difficult to determine until the US confirms its tariff plan. Today is the day when Trump previously stated he would finalize and announce his tariff plan. The administration has not yet released the policy, but investors expect it to be the most expansionary in a century. President Trump is due to speak at 20:00 GMT. On HFM's Calendar the speech is stated as "US Liberation Day Tariff Announcement". Currently, analysts are expecting Trump’s Tariff Plan to impose tariffs on the EU, chips and pharmaceuticals later today as well as reciprocal tariffs. Economists have a good idea of how these tariffs may take effect, but reciprocal tariffs are still unspecified. In addition to this, 25% tariffs on the car industry will start tomorrow. The tariffs on the foreign cars industry are a factor which will particularly impact Japan. Although, traders should note that this is what is expected and is not yet finalised. Last week, President Trump stated that he would implement retaliatory tariffs but allow exemptions for certain US trade partners. Treasury Secretary Mr Bessent and National Economic Council Director Mr Hassett suggested that the restrictions would primarily target 15 countries responsible for the bulk of the US trade deficit. However, yesterday, Trump contradicted these statements, asserting that additional duties would be imposed on any country that has implemented similar measures against US products. The day’s volatility will depend on which route the US administration takes. The harshness of the policy will influence both the Japanese Yen as well as the US Dollar.   USDJPY 5-Minute Chart   US Economic and Employment Data The JOLT Job Vacancies figure fell below expectations and is lower than the previous month’s figure. The JOLT Job Vacancies read 7.57 million whereas the average of the past 6 months is 7.78 million. The ISM Manufacturing Index also fell below the key level of 50.00 and was 5 points lower than what analysts were expecting. The data is negative for the US Dollar, particularly as the latest release applies more pressure on the Federal Reserve to cut interest rates. However, this is unlikely to happen if the trade policy ignites higher and stickier inflation. In the Bank of Japan’s Governor's latest speech, Mr Ueda said that the tariffs are likely to trigger higher inflation. USDJPY Technical Analysis Currently, the Japanese Yen Index is the worst performing of the day while the US Dollar Index is more or less unchanged. However, this is something traders will continue to monitor as the EU session starts. In the 2-hour timeframe, the USDJPY is trading at the neutral level below the 75-bar EMA and 100-bar SMA. The RSI and MACD is also at the neutral level meaning traders should be open to price movements in either direction. On the smaller timeframes, such as the 5-minute timeframe, there is a slight bias towards a bullish outcome. However, this is only likely if the latest bearish swing does not drop below the 200-Bar SMA.     The key resistant level can be seen at 150.262 and the support level at 149.115. Breakout levels are at 149.988 and 149.674. Key Takeaway Points: Job vacancies hit a five-month low, and the ISM Manufacturing PMI missed expectations, adding pressure on the Federal Reserve regarding interest rate decisions. Traders await confirmation on Trump’s tariff policy, which is expected to impact the EU, chips, pharmaceuticals, and foreign car industries. The severity of the tariffs will influence both the JPY and the USD, with traders waiting for final policy details. The Japanese Yen Index is the worst index of the day while the US Dollar Index is unchanged. Always trade with strict risk management. Your capital is the single most important aspect of your trading business.   Please note that times displayed based on local time zone and are from time of writing this report.   Click HERE to access the full HFM Economic calendar.   Want to learn to trade and analyse the markets? Join our webinars and get analysis and trading ideas combined with better understanding of how markets work. Click HERE to register for FREE!   Click HERE to READ more Market news.   Michalis Efthymiou HFMarkets   Disclaimer: This material is provided as a general marketing communication for information purposes only and does not constitute an independent investment research. Nothing in this communication contains, or should be considered as containing, an investment advice or an investment recommendation or a solicitation for the purpose of buying or selling of any financial instrument. All information provided is gathered from reputable sources and any information containing an indication of past performance is not a guarantee or reliable indicator of future performance. Users acknowledge that any investment in Leveraged Products is characterized by a certain degree of uncertainty and that any investment of this nature involves a high level of risk for which the users are solely responsible and liable. We assume no liability for any loss arising from any investment made based on the information provided in this communication. This communication must not be reproduced or further distributed without our prior written permission.
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.