Triangle Pattern Indicator Code Not Working

[clbradley 10]

Hey. Have tried this older Triangle Pattern Code I found on the net for Tradestation, but apparently the code has changed, and it doesn't recognize the word triangle. Can anyone help? Thanks.

 

Here's the code, indicator's at the bottom, function at the top:

 

Triangle Pattern Indicator by Walt Downs

 

Origin: omega-list

Written by: Walt Downs

Date found: 1 dec 97

 

Indicator calculates triangles based on SwingHighs and lows of a 10 day range, and with a swing strength of "1". Larger

triangles can be calculated by increasing the strength and/or HighestBar/LowestBar range settings. The indicator plots

a simple "spike" graph, alerting the trader to the presence of a triangle. The trader can then apply logical trendlines to establish break-out points.

 

 

 

Type : Function, Name : Triangle Pattern Indicator

 

input:

OccurH1(numericsimple),OccurH2(numericsimple),OccurL1(numericsimple),

OccurL2(numericsimple),PriceH1(numericseries),PriceH2(numericseries),

PriceL1(numericseries),PriceL2(numericseries),StrenH(numericsimple),

StrenL(numericsimple),Len(numericsimple);

 

value1 = SwingHighBar(OccurH1,PriceH1,StrenH,Len);

value2 = SwingHighBar(OccurH2,PriceH2,StrenH,Len);

value3 = SwingLowBar(OccurL1,PriceL1,StrenL,Len);

value4 = SwingLowBar(OccurL2,PriceL2,StrenL,Len);

 

 

Condition1 = high of value2 bars ago > high of value1 bars ago;

Condition2 = low of value4 bars ago < low of value3 bars ago;

Condition3 = HighestBar(H,Len) = value2;

Condition4 = LowestBar(low,Len) = value4;

 

if

Condition1 and

Condition2 and

Condition3 and

Condition4

then Triangle = true

else Triangle = false;

 

 

 

 

 

Type : Indicator, Name : Triangle Pattern Indicator

 

input:

OccurH1(1),

OccurH2(2),

OccurL1(1),

OccurL2(2),

PriceH1(high),

PriceH2(high),

PriceL1(low),

PriceL2(low),

StrenH(1),

StrenL(1),

Len(10);

 

if

Triangle(OccurH1,OccurH2,OccurL1,OccurL2,PriceH1,

PriceH2,PriceL1,PriceL2,StrenH,StrenL,Len)

= true then plot1(10,"TriFinder")

else plot1(0,"TriFinder");

 

if

Triangle(OccurH1,OccurH2,OccurL1,OccurL2,PriceH1,PriceH2,

PriceL1,PriceL2,StrenH,StrenL,Len)

= true then Alert = true;

[sevensa 10]

The name of the function needs to be "Triangle" when you create it.

[clbradley 10]

I made the function Triangle as you noted, yet keep getting an error message that says "Arithmetic (numeric) expression expected here". It is alluding to the word "true" in the 2nd to last sentence, "then Triangle = true"

 

It will probably say the same thing for false once I fix true. What Arithmetic (numeric) expression should I use instead of true or false near the end of the function code?

Thanks.

 

Curtis

[Tams 20]

The function Triangle returns a True or False condition.

 

When you set up the new function, TS would ask you for the return type.

 

Select TrueFalse.

[clbradley 10]

I am trying to verify, and if there were no errors (this box says Grammar error), then it says verification successful and no problem. This grammar error it blacks out the word "true" (and I tried replacing it with "TrueFalse" and get the same Grammor error message) and within the Grammar error box it says "Arithmetic (numeric) expression expected here. Underneath that you click a little box that says OK, and it just leaves you to figure out what to put instead of the blacked over true or TrueFalse, because they don't work. Have the 2nd to most recent platform, see one just came out within the last week, have Tradestation 8.4 (Build 1693). Try it if you're not sure, but it won't verify for me with true or TrueFalse there near the end after "then Triangle =". It seems to want a # I'm guessing by the "Arithmetic (numeric) expression expected here" message. Thanks for any help.

 

Curtis

[sevensa 10]

I am trying to verify, and if there were no errors (this box says Grammar error), then it says verification successful and no problem. This grammar error it blacks out the word "true" (and I tried replacing it with "TrueFalse" and get the same Grammor error message) and within the Grammar error box it says "Arithmetic (numeric) expression expected here. Underneath that you click a little box that says OK, and it just leaves you to figure out what to put instead of the blacked over true or TrueFalse, because they don't work. Have the 2nd to most recent platform, see one just came out within the last week, have Tradestation 8.4 (Build 1693). Try it if you're not sure, but it won't verify for me with true or TrueFalse there near the end after "then Triangle =". It seems to want a # I'm guessing by the "Arithmetic (numeric) expression expected here" message. Thanks for any help.

 

Curtis

 

To be honest, I have no idea what you are saying above, but attached is the code for the function and the indicator in .els format. I only have Tradestation 2000 but I guess TS 8.4 would be able to import .els files. Both compiled and I was able to apply the indicator to a chart, but I did not check if it shows anything meaningful.

TRIANGLE.zip

[clbradley 10]

Thanks for trying to help Tams and sevensa, but uploaded the function and indicator from your ELS, tried to use it, and get a TS box that says "study not verified". So I opened the indicator and tried to verify, and it said "Error found in function", and blacked over the word Triangle. So they must have changed what Easy Language (that's a laugh) is recognized between your platform and the more recent ones. Thanks again.

 

Curtis

[Tams 20]

Thanks for trying to help Tams and sevensa, but uploaded the function and indicator from your ELS, tried to use it, and get a TS box that says "study not verified". So I opened the indicator and tried to verify, and it said "Error found in function", and blacked over the word Triangle. So they must have changed what Easy Language (that's a laugh) is recognized between your platform and the more recent ones. Thanks again.

Curtis

 

1. every time you import, you must verify the codes before they can be used.

(another term for verify is "compile").

 

2. please first delete the "Triangle" function from your computer. The function needs to be set to TrueFalse. This will be done automatically when you import from ELS.

 

I have imported the above codes to MultiCharts and they compile with no problem.

[clbradley 10]

Sorry, Multicharts is very different from TS. Things and words that worked on a previous platform at TS won't work on a newer one, and have found that it won't recognnize several words frequently in older codes, and this one is from 1997. I did delete everything, and someone at TS told me to change the function from numeric while starting a new one, to boolean (true/false), and that function verified, and so did the indicator, and tried to use it on a chart, nothing showed up, but received a pop up TS events log that stated "tried to reference future data". May just have to do without this indicator, it just doesn't seem compatible for the latest platform of TS with this code. Thanks for your help.

 

Curtis

[BlowFish 10]

I would persevere. The fact it works for Tams & Svensa suggests it is not a problem with the indicator.

 

When it comes to easy language MC & TS are not very different. Quite the reverse.

 

Edit: There does appear to be bug in the codes logic in so far as it references a bar in the future.

Edited February 20, 2009 by BlowFish

[Tams 20]

Sorry, Multicharts is very different from TS. Things and words that worked on a previous platform at TS won't work on a newer one, and have found that it won't recognnize several words frequently in older codes, and this one is from 1997. I did delete everything, and someone at TS told me to change the function from numeric while starting a new one, to boolean (true/false), and that function verified, and so did the indicator, and tried to use it on a chart, nothing showed up, but received a pop up TS events log that stated "tried to reference future data". May just have to do without this indicator, it just doesn't seem compatible for the latest platform of TS with this code. Thanks for your help.

Curtis

 

The indicator and function VERIFIED !

That's the important thing; that means the code was good.

You have achieved a mile stone.

Congratulations,

Give yourself a pad on the back.

 

The error message "tried to reference future data" means the indicator is a very sensitive one: you need to adjust the variables to meet the chart's volatility.

 

Go into Format Study and change the "Len" to 30.

You can use this as a starting point to fine tune the indicator.

[thrunner 10]

Well, everybody is right on this one, and welcome to the forum, Curtis.

 

Every version of MC and TS is slightly different in error checking and the recent versions of TS tend to stop indicators from functioning if they attempt to reference non existing values, such as the future data that you mentioned.

 

In order to correct this, please replace the 4 lines (value1...value4) with the following code fragment in the Triangle function:

 

if SwingHighBar(OccurH1,PriceH1,StrenH,Len) <> -1 then
value1 = SwingHighBar(OccurH1,PriceH1,StrenH,Len);
if SwingHighBar(OccurH2,PriceH2,StrenH,Len) <> -1 then
value2 = SwingHighBar(OccurH2,PriceH2,StrenH,Len);
if SwingLowBar(OccurL1,PriceL1,StrenL,Len) <> -1 then
value3 = SwingLowBar(OccurL1,PriceL1,StrenL,Len);
if SwingLowBar(OccurL2,PriceL2,StrenL,Len) <> -1 then
value4 = SwingLowBar(OccurL2,PriceL2,StrenL,Len);

 

Alternatively, use this revised Triangle function:

[LegacyColorValue = true]; 

input:
OccurH1(numericsimple),OccurH2(numericsimple),OccurL1(numericsimple),
OccurL2(numericsimple),PriceH1(numericseries),PriceH2(numericseries),
PriceL1(numericseries),PriceL2(numericseries),StrenH(numericsimple),
StrenL(numericsimple),Len (numericsimple);

if SwingHighBar(OccurH1,PriceH1,StrenH,Len) <> -1 then
value1 = SwingHighBar(OccurH1,PriceH1,StrenH,Len);
if SwingHighBar(OccurH2,PriceH2,StrenH,Len) <> -1 then
value2 = SwingHighBar(OccurH2,PriceH2,StrenH,Len);
if SwingLowBar(OccurL1,PriceL1,StrenL,Len) <> -1 then
value3 = SwingLowBar(OccurL1,PriceL1,StrenL,Len);
if SwingLowBar(OccurL2,PriceL2,StrenL,Len) <> -1 then
value4 = SwingLowBar(OccurL2,PriceL2,StrenL,Len);


Condition1 = high of value2 bars ago > high of value1 bars ago;
Condition2 = low of value4 bars ago < low of value3 bars ago;
Condition3 = HighestBar(H,Len) = value2;
Condition4 = LowestBar(low,Len) = value4;

if 
Condition1 and
Condition2 and
Condition3 and
Condition4
then Triangle = true
else Triangle = false;

[moneymarkets 10]

Tams, did you get a plot error in MC, trying to reference future data -1 error? I did, so just wondering if you knew how to solve the error. I tried adding more space on it, but still error?

Thanks

[Tams 20]

Tams, did you get a plot error in MC, trying to reference future data -1 error? I did, so just wondering if you knew how to solve the error. I tried adding more space on it, but still error?

Thanks

you can see my post above.

[nkhoi 10]

you can see my post above.

Great Scott! Now I had to come here more often.

[walidsaleh 10]

anyone has a pattern ELD to identify triangles? I get error "tried to refer future data. Help would be appreciated on fixing above. Thanks

[walidsaleh 10]

Finally got it to work but not that great. Here you go

TRIANGLE PATTER.ELD